Re: Why does WAL_DEBUG macro need to be defined by default? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Why does WAL_DEBUG macro need to be defined by default?
Date
Msg-id CA+TgmoYP-oj0aAMOAqtHmDAxq=41NVNDG3GMEn3MH1kFdxsDAQ@mail.gmail.com
Whole thread Raw
In response to Re: Why does WAL_DEBUG macro need to be defined by default?  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
Responses Re: Why does WAL_DEBUG macro need to be defined by default?
List pgsql-hackers
On Fri, Oct 7, 2011 at 1:03 PM, Kevin Grittner
<Kevin.Grittner@wicourts.gov> wrote:
> Robert Haas <robertmhaas@gmail.com> wrote:
>> The funny thing is that I've been thinking all of these months
>> about how convenient it is that we defined WAL_DEBUG in debug
>> builds
>
> IMO, --enable-debug should not do anything but include debugging
> symbols.  The ability to get a useful stack trace from a production
> crash, without compromising performance, is just too important by
> itself to consider conditioning any other behavior on it.

So, should I go revert this change in head and 9.1, or does anyone
else want to argue for Heikki's position that we should just leave it
on, on the theory that it's too cheap to matter?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Why does WAL_DEBUG macro need to be defined by default?
Next
From: "Dickson S. Guedes"
Date:
Subject: [PATCH] Fix little typo in docs in func.sgml