Re: bgworker crashed or not? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: bgworker crashed or not?
Date
Msg-id CA+TgmoYMwCEHPMFncQApBTj0VsjFSty0k1RaktNA+2PLG9u8eA@mail.gmail.com
Whole thread Raw
In response to Re: bgworker crashed or not?  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: bgworker crashed or not?
Re: bgworker crashed or not?
List pgsql-hackers
On Wed, May 7, 2014 at 4:55 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
>> This isn't done yet.
>
> Unless I am missing something this change was included in every patch I sent
> - setting rw->rw_terminate = true; in CleanupBackgroundWorker for zero exit
> code + comment changes. Or do you have objections to this approach?
>
> Anyway missing parts attached.

It was, but I felt that the different pieces of this should be
separated into separate commits, and (regardless of how I committed
it) I needed to review each change separately.  I wasn't saying it was
your fault that it wasn't done; just that I hadn't gotten it committed
yet.

I've pushed your rebased patch now with some further kibitzing,
especially in regards to the documentation.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers
Next
From: Robert Haas
Date:
Subject: Re: pg_shmem_allocations view