Postgres Pro
Downloads
Home   >   mailing lists

Re: improving basebackup.c's file-reading code - Mailing list pgsql-hackers

From Robert Haas
Subject Re: improving basebackup.c's file-reading code
Date
Msg-id CA+TgmoYLV7Dm7Yr6yXRF09kW1SK3AJEYTFkgj2qwZCJduyn5WA@mail.gmail.com
Whole thread Raw
In response to Re: improving basebackup.c's file-reading code  (Hamid Akhtar <hamid.akhtar@gmail.com>)
Responses Re: improving basebackup.c's file-reading code  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view 
On Wed, Apr 29, 2020 at 5:52 AM Hamid Akhtar <hamid.akhtar@gmail.com> wrote:
> The idea and the patch looks good to me.
>
> It makes sense to change fread to basebackup_read_file which internally calls pg_pread which is a portable function
asopposed to read. As you've mentioned, this is much better for error handling.
 

Thanks for the review. I have now committed the patch, after rebasing
and adjusting one comment slightly.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Jehan-Guillaume de Rorthais
Date:
Subject: [patch] demote
Next
From: Robert Haas
Date:
Subject: Re: [Patch] ALTER SYSTEM READ ONLY