Re: Improving planner's checks for parallel-unsafety - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Improving planner's checks for parallel-unsafety
Date
Msg-id CA+TgmoYF9CbCjs5jg4BiOaAMMdcyyY93jgbu96_XOqJrof3oqw@mail.gmail.com
Whole thread Raw
In response to Re: Improving planner's checks for parallel-unsafety  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Aug 18, 2016 at 5:07 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> I have reviewed this and it looks good to me.  My only comment is that
>> this comment is slightly confusing:
>
>> !  * Returns the first of PROPARALLEL_UNSAFE, PROPARALLEL_RESTRICTED, or
>> !  * PROPARALLEL_SAFE that can be found in the given parsetree.  We use this
>
>> "First" might be read to mean "the first one we happen to run across"
>> rather than "the earliest in list ordering".
>
> Thanks for the review.  I'll reconsider how to phrase that --- have you
> any suggestions?

I think what you committed is fine.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: Any need of GRANT/REVOKE CREATE TABLE | POLICY | ETC
Next
From: Robert Haas
Date:
Subject: Re: dsm_unpin_segment