Postgres Pro
Downloads
Home   >   mailing lists

Re: walsender doesn't send keepalives when writes are pending - Mailing list pgsql-hackers

From Robert Haas
Subject Re: walsender doesn't send keepalives when writes are pending
Date
Msg-id CA+TgmoY=uNPzicCxLgXDZ5Hzo41Z9EybjtNGmEF=GeOd+6CfOw@mail.gmail.com
Whole thread Raw
In response to Re: walsender doesn't send keepalives when writes are pending  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: walsender doesn't send keepalives when writes are pending  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Tue, Feb 25, 2014 at 10:54 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> I am not sure I can follow. Why doesn't it make sense to send out the
> keepalive (with replyRequested = true) when we're busy sending stuff
> (which will be the case most of the time on a busy server)?

It may very well make sense, but your patch won't generally have that
effect, because with the patch you proposed, the keep-alive can only
be sent when the server is busy if the write queue is also full.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: jsonb and nested hstore
Next
From: Andres Freund
Date:
Subject: Re: walsender doesn't send keepalives when writes are pending