Postgres Pro
Downloads
Home   >   mailing lists

Re: Proposal: "Causal reads" mode for load balancing reads without stale data - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Proposal: "Causal reads" mode for load balancing reads without stale data
Date
Msg-id CA+TgmoY8bunyH0MV=P81XPe3vOrfOjk9TaqJmnZmW02sM3U+aQ@mail.gmail.com
Whole thread Raw
In response to Re: Proposal: "Causal reads" mode for load balancing reads without stale data  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Proposal: "Causal reads" mode for load balancing reads without stale data  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Tree view 
On Tue, Mar 29, 2016 at 3:17 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> OK, so I am switching this patch as "Ready for committer", for 0001.
> It is in better shape now.

Well...  I have a few questions yet.

The new argument to SyncRepWaitForLSN is called "bool commit", but
RecordTransactionAbortPrepared passes true.  Either it should be
passing false, or the parameter is misnamed or at the least in need of
a better comment.

I don't understand why this patch is touching the abort paths at all.
XactLogAbortRecord sets XACT_COMPLETION_SYNC_APPLY_FEEDBACK, and
xact_redo_abort honors it.  But surely it makes no sense to wait for
an abort to become visible.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PROPOSAL] Client Log Output Filtering
Next
From: Robert Haas
Date:
Subject: Re: [PROPOSAL] Client Log Output Filtering