Re: extend pgbench expressions with functions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: extend pgbench expressions with functions
Date
Msg-id CA+TgmoY+1aucvEtRBS=Kdit7kp-8BEFgHe-9rWS_TneXvsohsw@mail.gmail.com
Whole thread Raw
In response to Re: extend pgbench expressions with functions  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: extend pgbench expressions with functions
List pgsql-hackers
On Sat, Nov 7, 2015 at 2:45 AM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> After looking at the generated html version, I find that the "1/param" and
> "2/param" formula are very simple and pretty easy to read, and they would
> not be really enhanced with additional spacing.
>
> ISTM that adaptative spacing (no spacing for level 1 operations, some for
> higher level) is a good approach for readability, ie:
>
>    f(i) - f(i+1)
>              ^ no spacing here
>         ^ some spacing here
>
> So I would suggest to keep the submitted version, unless this is a blocker.

Well, I think with the ".0" version it looks more like floating-point
math, and I like the extra white-space.  But I'm happy to hear other
opinions.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Uh-oh: documentation PDF output no longer builds in HEAD
Next
From: Robert Haas
Date:
Subject: Re: Some questions about the array.