Re: [PATCH] pg_convert improvement - Mailing list pgsql-hackers

From Yurii Rashkovskii
Subject Re: [PATCH] pg_convert improvement
Date
Msg-id CA+RLCQzAbj6yFd2-PZaMJNjSxQNyZAU_Y+Z2FLKFPbUo5iCf7w@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pg_convert improvement  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
Responses Re: [PATCH] pg_convert improvement
List pgsql-hackers
Hi Bertrand,

On Fri, Nov 24, 2023 at 6:26 AM Drouvot, Bertrand <bertranddrouvot.pg@gmail.com> wrote:

The patch is pretty straightforward, I just have one remark:

+       /* if no actual conversion happened, return the original string */
+       /* (we are checking pointers to strings instead of encodings because
+          `pg_do_encoding_conversion` above covers more cases than just
+          encoding equality) */

I think this could be done in one single comment and follow the preferred style
for multi-line comment, see [1].

Thank you for your feedback. I've attached a revised patch. 

--
Y.

Attachment

pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: [PATCH] pg_convert improvement
Next
From: Heikki Linnakangas
Date:
Subject: Re: Stack overflow issue