Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name - Mailing list pgsql-hackers

From Yurii Rashkovskii
Subject Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name
Date
Msg-id CA+RLCQyBKNsqmumxMkFx_Fvr6bGKnmY8sxywAnxmyqPxix7tsg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name
List pgsql-hackers
Tree view
Hi Nathan,

On Fri, Jun 30, 2023 at 2:39 PM Nathan Bossart <nathandbossart@gmail.com> wrote:

In v4, I've introduced a new BGW_LIBLEN macro and set it to the default
value of MAXPGPATH (1024).  This way, the value can live in bgworker.h like
the other BGW_* macros do.  Plus, this should make the assertion that
checks for backward compatibility unnecessary.  Since bgw_library_name is
essentially a path, I can see the argument that we should just set
BGW_LIBLEN to MAXPGPATH directly.  I'm curious what folks think about this.

Thank you for revising the patch. While this is relatively minor, I think it should be set to MAXPGPATH directly to clarify their relationship.

--
Y.

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: possible bug in handling of contrecords in dd38ff28ad (Fix recovery_prefetch with low maintenance_io_concurrency)
Next
From: David Rowley
Date:
Subject: Re: Making empty Bitmapsets always be NULL