Re: Require suggestion for issue #6513 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Require suggestion for issue #6513
Date
Msg-id CA+OCxozsq3n+aKTERxN3JtcowEGk2RhpHg13P3robQ_MWZVGGg@mail.gmail.com
Whole thread Raw
In response to Re: Require suggestion for issue #6513  (Rohit Bhati <rohit.bhati@enterprisedb.com>)
List pgadmin-hackers
Hi Rohit!

On Wed, 27 Nov 2024 at 07:12, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:

Hi Dave,

I hope you're doing well. I would greatly appreciate it if you could provide your suggestions also on this issue.


I'm fine with the button label changes. We should make sure the text is structured consistently though:

Are you sure you want to disconnect from the database "FooBar"?

Are you sure you want to delete the database "FooBar"?

For the delete option, I would also:

- Make Cancel the default option.
- Colour the button ("danger" in the palette)

Thanks!
 

Thank you in advance.

Best regards,
Rohit Bhati


On Thu, Nov 21, 2024 at 11:40 PM Usman Khan <umk555@gmail.com> wrote:
Yes, I think it would be nice to do it across all appropriate places.
'Disconnect' is available for Server and Database, while Delete is available across all database objects in the tree area.





On Thu, Nov 21, 2024 at 12:48 PM Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:

Hi Hackers,

I have been working on issue #6513 and have implemented some changes based on user suggestions. Here’s a summary of the modifications I made locally:

  1. Button Label Changes:
    • Updated the labels of the buttons to "Delete" or "Disconnect" for affirmative actions.
    • Changed the label "No" to "Cancel" for negative actions.
  2. Icon Additions:
    • Added appropriate icons for the "Disconnect" and "Delete" actions.

I would like your input on whether these changes should be applied universally across all delete and disconnect scenarios, or if they should be limited to just the database delete and disconnect actions.

Please find the attached screenshots showcasing the changes.


Thank you for your feedback!

Best regards,
Rohit Bhati

 



--

pgadmin-hackers by date:

Previous
From: Anil Sahoo
Date:
Subject: Require suggestions on feature #5766
Next
From: Dave Page
Date:
Subject: Re: Require suggestions on feature #5766