Re: Regarding feature #6841 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Regarding feature #6841
Date
Msg-id CA+OCxozieNmgfoGFq0G0Mxy+bu2Ct6hK9goZA3xtVJm9EaK6HA@mail.gmail.com
Whole thread Raw
In response to Regarding feature #6841  (Anil Sahoo <anil.sahoo@enterprisedb.com>)
Responses Re: Regarding feature #6841
List pgadmin-hackers
Hi

On Wed, 17 Apr 2024 at 15:08, Anil Sahoo <anil.sahoo@enterprisedb.com> wrote:
Hi Hackers,

This feature is about executing a query at the cursor position. And that query can be a one line or multiline. I have assigned a play icon button and F5 as the keyboard shortcut for the Execute Query feature, and for Execute Script, Playlist icon button and Alt+F5(Others),Option+F5(Mac) as keyboard shortcut.

As now the query can run at cursor position, so for user convenience I am showing the current query just beside the Data Output toolbar. And on hover of the text, it will show the whole query as a tooltip. This query text will be available for both Execute Script and Execute Query.

I have made the UI change for the feature #6841

Please provide your suggestions and feedback if these changes look okay to you.

How is this parsing the query to figure out the correct text to send to the server? For example, I notice you have no semi-colons on many of the queries in your test; is it breaking on newlines? What if there's a newline (or multiple of them) in the query string? How does it cope with an anonymous block containing multiple queries, or a pl/whatever function definition that might contain queries within its text? Or a view definition?
 
--

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: Keyboard shortcut challenges
Next
From: Anil Sahoo
Date:
Subject: Re: Regarding feature #6841