Re: Observed issue in pgAdmin3 while creating Type object - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Observed issue in pgAdmin3 while creating Type object
Date
Msg-id CA+OCxozNscEy=J9K7Km94cB5zU1N-V79vRQArF82wo4kyW6o0w@mail.gmail.com
Whole thread Raw
In response to Re: Observed issue in pgAdmin3 while creating Type object  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers

On Thu, Jan 28, 2016 at 9:34 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

To fix this I have used "qtTypeIdent" instead of "qtIdent". I have found one more issue, in case of Edit mode options related to Range information has not been populated for existing Type, the problem here is as per the wxWidget documentation for a combobox with wxCB_READONLY style the string must be in the combobox list, otherwise the call to SetValue() is ignored.

To fix this instead of using "SetValue()" I have used "Append" method and also disable all the controls in case of Edit mode as user can't change it.

Attached is the patch file to fix this issue 

Thanks. I was just looking at this and it seems like the whole dialogue is pretty unusable. Please see the attached screen shot - aside from the ridiculous number of controls on there, you'll note that the grid that should list the members of the type only shows it's headers.

Can you see what got messed up here? I don't believe anyone ever intentionally designed that dialogue like that.

I've committed the first patch - thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Properly quote type names in the Type dialogue, and
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Properly quote type names in the Type dialogue, and