Re: [GSoC][New Feature] Editable and Read-only Columns - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [GSoC][New Feature] Editable and Read-only Columns
Date
Msg-id CA+OCxozK+k3Dh7NaP+iu_3Ef5OjH3XY4qY8tngj0YKo0F0zFdg@mail.gmail.com
Whole thread Raw
In response to [GSoC][New Feature] Editable and Read-only Columns  (Yosry Muhammad <yosrym93@gmail.com>)
Responses Re: [GSoC][New Feature] Editable and Read-only Columns  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Aditya, can you review this please?

Thanks.

On Thu, Aug 15, 2019 at 8:01 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi, hackers !

Please find attached a work-in-progress patch adding a new feature to the Query Tool on top of updatable result-sets.

This patch allows individual columns of an updatable result-set to be editable or read-only. This allows for a wider variety of updatable result-sets, for example:

- Result-sets with duplicated columns.
- Result-sets with renamed columns (if a column is renamed to a primary key name, the real primary key can be correctly identified) .
- Result-sets including columns that are not selected directly from a table (e.g concatenation of 2 columns or system columns).

In the above cases, these columns would be read-only while other columns of the result-set are editable. Editable/Read-only columns are identified by icons and tooltips in the column header.

This is still a work-in-progress, updates to tests and documentation is still due. Looking forward to your thoughts and feedback!

Also, do you think the editable/read-only icons should apply in both View/Edit Data and Query Tool for consistency? or hidden from View/Edit Data as all columns are editable anyway?

Thanks.

--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: RM 4463 - MSQL test cases for domain node
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Add Reverse Engineered SQL tests for Rules. Fixes #46