Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries
Date
Msg-id CA+OCxozFf0Y9thW7mSpRO8P9SCes=b9-A2ePd6gAOHTgbPfc0g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][4709] Invalid FTS configuration token dictionaries  (Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Akshay,

On Wed, Apr 15, 2020 at 10:42 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave


On Wed, Apr 15, 2020 at 1:31 PM Dave Page <dpage@pgadmin.org> wrote:


On Wed, Apr 15, 2020 at 8:25 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Ganesh

As per my understanding, the dictionary names from "pg_catalog" should not be schema-qualified. Please make appropriate changes and send the patch again.

@Dave/@Ashesh thoughts?

Maybe I'm missing something, but I don't see why not. If anything, I'd argue it's defensive programming, that makes good sense.

    I am talking about showing that on GUI, please refer the below screenshot:
       FTS_Config.png

Yeah, we shouldn't show it in the UI. I was referring to underlying code (e.g. test cases), which should general be schema qualified where possible imho.
 
 
 


On Tue, Apr 14, 2020 at 5:37 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add schema qualified dictionary names in FTS configuration to overcome the confusion of duplicate dictionary names.

Also modified the resql test cases accordingly.

Please review.

Regards,
Ganesh Jaybhay


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger thanunderlying field size
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - RM 4957 - Constraint Trigger, Deferrable,Deferred option should be disbled if user select EDB-SPL function for triggerfor EPAS.