Postgres Pro
Downloads
Home   >   mailing lists

Re: Raise an exception under Python < 3.4 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Raise an exception under Python < 3.4
Date
Msg-id CA+OCxoz8Rtg+s+wZ0G_yjpKSH8Mqkf+ixmCJ=a-myisFQhUJug@mail.gmail.com
Whole thread Raw
In response to Re: Raise an exception under Python < 3.4  (Neel Patel <neel.patel@enterprisedb.com>)
Responses Re: Raise an exception under Python < 3.4  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Wed, Apr 29, 2020 at 10:13 AM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Patch looks good to me except one condition as we do support from Python 3.4 onwards. I have modified that condition and attached the updated patch.

What did you change exactly (curious about what I missed)?
 

I have also removed the other references of Python2. Attached is the patch. Do review it and let me know for comments.

I think there's a lot more than that - try searching the entire tree for PY2 or sys.version. This was on my personal todo as a next step, but feel free to update your patch :-)

Thanks!
 

Thanks,
Neel Patel

On Mon, Apr 27, 2020 at 9:27 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch raises an exception if run under Python < 3.4. It also cleans up the README to remove references to Python 2 and removes Python 2-isms from the main config.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: Raise an exception under Python < 3.4
Next
From: Neel Patel
Date:
Subject: Re: Raise an exception under Python < 3.4