On Tue, Mar 30, 2021 at 3:36 PM Florian Sabonchi <sabonchi@posteo.de> wrote:
Hello in this patch I have implemented oauth2
Cool!
Unfortunately the patch seems to be messed up. It adds a number of commits that are already in the primary repo, and attempts to remove your OAuth support, rather than adding it. Can you rebase it and make sure it only includes the addition of your work please?
Some other comments (keep in mind it's hard to read the mangled patch, so I may be missing something):
- There don't seem to be any documentation updates
- There don't seem to be any tests (which I grant may not be feasible to add unless an OAuth service can be mocked)
- I can't see how you've dealt with password saving, which currently requires a password from the user to be secure.
