Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4] [Patch]: Foreign Table Module - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4] [Patch]: Foreign Table Module
Date
Msg-id CA+OCxoz26u=CXOHzZkS=x_nTBjQFRzhUa3Yhb0J1hqhutxV_ow@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4] [Patch]: Foreign Table Module  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: [pgAdmin4] [Patch]: Foreign Table Module  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Tree view


On Mon, May 9, 2016 at 1:23 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Mon, May 9, 2016 at 5:50 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached updated patch for the Foreign Tables module.

Feedback from my initial testing:

- Owner is missing from the New dialogue.

- The Properties list shows "Select from the list" in a combo box for Owner and
  Inherits.
  
- s/Oid/OID

- s/Foreign Server/Foreign server

- SQL Help filenames are not defined.

- SQL formatting is weird, e.g.

CREATE FOREIGN TABLE public.redis_table
(id text NOT NULL COLLATE pg_catalog."default",
value text NULL COLLATE pg_catalog."default")
    SERVER redis_server1
    OPTIONS (database '0');
    
instead of:

CREATE FOREIGN TABLE public.redis_table (
    id text NOT NULL COLLATE pg_catalog."default",
    value text NULL COLLATE pg_catalog."default"
)
    SERVER redis_server1
    OPTIONS (database '0');
    
- In the validation error messages, please replace ! with . and "can not" with 
  "cannot" for consistency with recently reviewed strings.
  
- s/mulitple/multiple (in the js).

- How do I manage the ACL? 

Thanks.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: [pgAdmin4]: Maintenance tool for vaccum operation
Next
From: Murtuza Zabuawala
Date:
Subject: Re: [PATCH] Tables node (pgAdmin4)