Postgres Pro
Downloads
Home   >   mailing lists

Re: ESLINT: On pgAdmin static javascripts - Mailing list pgadmin-hackers

From Dave Page
Subject Re: ESLINT: On pgAdmin static javascripts
Date
Msg-id CA+OCxoyt+WGQtgrj3PvbzURjPumAv7ZspjMZT0Ep2vXNMzacpA@mail.gmail.com
Whole thread Raw
In response to ESLINT: On pgAdmin static javascripts  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: ESLINT: On pgAdmin static javascripts
List pgadmin-hackers
Tree view
Hi

I think these are impossibly big to properly review by hand, especially where much of them are whitespace changes.

I think the best option is to check the regression tests all pass, do some manual testing yourself, and then commit. 

On Mon, Jan 8, 2018 at 1:55 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Dave/Team,

I found many problems while 'eslint' utility on all the static javascript files of pgAdmin 4.
i.e. <pgAdmin4_path>/web/node_module/.bin/eslint <file_name>

I had fixed all errors reported by eslint for those files.

I have created six patches for ease of maintenance, as possibilities of conflicting with other patches.
* Browser nodes javascript files
* Browser specific javascript files
* pgAdmin common javascript files
* SQLEditor/DataGrid javascript files
* Tools javascript files
* Miscellaneous modules javascript files

All patches are independent of each other.

Please review it, and share your opinion.
  

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Harshal Dhumal
Date:
Subject: Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires
Next
From: Ashesh Vashi
Date:
Subject: Re: ESLINT: On pgAdmin static javascripts