Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling
Date
Msg-id CA+OCxoyXBJyN_B-4RANjh0iQ96TckNqhLBprh+hy4D=fiPqJ8Q@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Responses Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers


On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:


On Jul 21, 2017 4:23 PM, "Dave Page" <dpage@pgadmin.org> wrote:


On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

On Fri, Jul 21, 2017 at 2:24 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

Currently if user clicks on empty white area below history entry then arrow navigation does not work.
Attached patch fixes this issue.

This fixes that problem, but stops it working if I *don't* click on the white area first. We need both I think :-)
Yes we need both. Please find updated patch

Why all the changes to yarn.lock?
Are there? I can't see any changes.

Huh, no, you're right. Looks like my machine is rewriting it for some reason. I'll dig deeper.

Sorry for the noise.
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python34 #249
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Ensure arrow keys work correctly when the pane isfoc