Re: little patch for "Detect serial columns from pg_depend" and bugfix - Mailing list pgadmin-hackers

Hi

On Tue, Sep 4, 2012 at 5:03 AM, Quan Zongliang <quanzongliang@gmail.com> wrote:
> Hi,
>
> Please find the attachments.
>
> pgColumn.patch:
>
> Detect serial columns from pg_depend, not column default (observe deviating
>   serial name)

This patch does not apply:

raptor:pgAdmin3 dpage$ git apply ~/Downloads/pgColumn.patch
/Users/dpage/Downloads/pgColumn.patch:13: trailing whitespace.
        pgSet *set = ExecuteSet(
/Users/dpage/Downloads/pgColumn.patch:14: trailing whitespace.
                            wxT("SELECT classid\n")
/Users/dpage/Downloads/pgColumn.patch:15: trailing whitespace.
                            wxT("  FROM pg_depend\n")
/Users/dpage/Downloads/pgColumn.patch:16: trailing whitespace.
                            wxT(" WHERE refobjid=") + table->GetOidStr() +
/Users/dpage/Downloads/pgColumn.patch:17: trailing whitespace.
                            wxT(" AND refobjsubid = ") + NumToStr(GetColNumber()) +
error: patch failed: pgadmin/schema/pgColumn.cpp:338
error: pgadmin/schema/pgColumn.cpp: patch does not apply

> pgSequence.patch:
>
> bugfix, in SQL pane of the sequence, the script is
>
> CREATE SEQUENCE xxx
>   ...;
> ALTER TABLE ...

That syntax is intentional - it's required with 8.3 and earlier, which
don't support ALTER SEQUENCE ... OWNER. I suppose we could make it
version dependent, but we don't normally both with multiple versions
of the same command unless required.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company