Re: [pgAdmin4][Patch]: To fix the issue in Debugger module - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: To fix the issue in Debugger module
Date
Msg-id CA+OCxoyQBkgfj_QArVM4uudAqdkEFg+3EUntrK8-DANJ0UVqeA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: To fix the issue in Debugger module  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied! On Mon, Dec 4, 2017 at 6:13 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > On Sat, Dec 2, 2017 at 10:42 AM, Dave Page wrote: > >> Hi >> >> On Thursday, November 30, 2017, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to fix the issue where debugger failed to run when user tries >>> to debug the function which call itself recursively. >>> RM#2524 >>> >> >> This seems to fix the recursion problem, but walking the stack doesn't >> work - no matter which frame I click on, the highlighted source code line >> remains that of the top frame, as does the value of in_val on the >> Parameters tab. >> > ​Fixed.​ > > ​It's due to improper conditional logic to select frame id in JS code.​ > > >> >> Thanks. >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix debugging of self-referencing functions. Fixes#2
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Prevent the user pressing the select button in thefi