It is failing irrespective of patch applied or not. :)
However, I have fixed it. Attached is the updated patch.
I have also flag for chromedriver 75.
Just to add, I have also changed "Filtered Rows" dialog title to add table details also.
Kindly review.
On Tue, Jun 11, 2019 at 2:50 PM Dave Page <dpage@pgadmin.org> wrote:
Hi
This doesn't pass the feature tests:
====================================================================== ERROR: runTest (pgadmin.feature_tests.browser_tool_bar_test.BrowserToolBarFeatureTest) Browser tool bar feature test ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test.py", line 55, in runTest self.test_filtered_rows_tool_button() File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test.py", line 112, in test_filtered_rows_tool_button ".alertify .ajs-header[data-title='Data Filter']") File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 305, in find_by_css_selector lambda driver: driver.find_element_by_css_selector(css_selector) File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 485, in wait_for_element self._wait_for("element to exist", element_if_it_exists) File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 560, in _wait_for "Timed out waiting for " + waiting_for_message File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/selenium/webdriver/support/wait.py", line 80, in until raise TimeoutException(message, screen, stacktrace) selenium.common.exceptions.TimeoutException: Message: Timed out waiting for element to exist