Re: RE-SQL tests for Roles & Resource Group nodes - Mailing list pgadmin-hackers

From Dave Page
Subject Re: RE-SQL tests for Roles & Resource Group nodes
Date
Msg-id CA+OCxoyEVimkOdA4rsFzjagsCseZMbpHCk3Uub_MEuhk4+mM8A@mail.gmail.com
Whole thread Raw
In response to Re: RE-SQL tests for Roles & Resource Group nodes  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: RE-SQL tests for Roles & Resource Group nodes
List pgadmin-hackers
Hi

On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
++ Attaching patch

On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

Please find the updated patch,

- Added a mechanism to check for supported minimum/maximum version and a server type in the framework.

There's still a problem with this I'm afraid - it says in the summary that the re_sql test cases were all skipped, which is not the case. I think we should just skip the irrelevant tests in the re_sql module, but not mark the entire module as being skipped:

=============Running the test cases for 'Regression - PG 11'=============

runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)

Reverse Engineered SQL Test Cases


Create IMPLICIT Cast

Alter IMPLICIT Cast

Drop IMPLICIT Cast

Create EXPLICIT Cast

Alter EXPLICIT Cast

Drop EXPLICIT Cast

 ... skipped 'Server(Type: #ppas) is not supported for the Resource Groups module'


----------------------------------------------------------------------

Ran 1 test in 0.480s


OK (skipped=1)


======================================================================

Test Result Summary

======================================================================


Regression - PG 11:


0 tests passed

0 tests failed

1 test skipped:

ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)


======================================================================
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: pgAdmin4 v4.10 candidate builds
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Correct the condition to compare version for Windows