Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window. - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.
Date
Msg-id CA+OCxoy8usbWf6NVYwBUop+dWffCZzCcoPb7TgCWnbo4_srPJw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM #2899: Provide access keys/shortcuts to allcommonly used menu options in the main window.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Thanks, applied!

A couple of things that need some more investigation/thought though:

- Pressing Escape in the Query Tool and then using Alt+Shift+[ (or ] ) seems to behave oddly:

  - Sometimes it will work once, but then won't navigate to additional tabs.
  - It often seems to fill the Codemirror on the query tool with garbage.

I suspect what is happening is that although it's hidden, the Codemirror instance is grabbing the second and subsequent key presses and trying to display them.

- Should we put the shortcuts on the main menus? We have them on tooltips and button menus elsewhere, so it seems like we should.

On Thu, Feb 8, 2018 at 7:08 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for RM #2899: Provide access keys/shortcuts to all commonly used menu options in the main window.

Shortcuts provided in this patch:

Alt+Shift+Q Open the query tool
Alt+Shift+V View data
Alt+Shift+C Open the context menu
Alt+Shift+N Create an object
Alt+Shift+E Edit the object properties
Alt+Shift+D Delete the object
Alt+Shift+G Direct debugging


Thanks,
Khushboo



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Add configurable shortcut keys for various commonopt
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Build failed in Jenkins: pgadmin4-master-python26 #604