On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote:
>> Hi Dave
>>
>> Modified the logic. Attached is the patch file, please review it.
>>
>
> This is still wrong. bIsChangeComment isn't always true when the user
> creates a replication cluster. It's only true if there is a comment.
Seems a little long-winded too - can't you just replace the current
IsEmpty() test with something like "if (txtComment->GetValue() !=
cluster->GetComment())"?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
