Re: Dark mode styling for the website - Mailing list pgsql-www

From Dave Page
Subject Re: Dark mode styling for the website
Date
Msg-id CA+OCxoxpEh7Z_THj9fSD4sSBsMWcCLDbJtOT3phuNhbk1ir5fw@mail.gmail.com
Whole thread Raw
In response to Re: Dark mode styling for the website  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Dark mode styling for the website
List pgsql-www
Hi

On Mon, 3 Jul 2023 at 16:29, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 3 Jul 2023, at 17:15, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2023-Jul-03, Euler Taveira wrote:
>
>> I don't know what Alvaro's OS is but I see the white background that he described.
>
> Yep, this is exactly what I see.  I'm running ungoogled-chromium:
>
>  Versión 114.0.5735.198 (Official Build, ungoogled-chromium) (64 bits)

It shows up in Firefox, Safari and Chrome for me, the issue is that the thead
element still has class thead-light even after switching to dark mode:

<thead class="thead-light">
    <tr>
      <th>Version</th>
      <th>Current minor</th>
      <th>Supported</th>
      <th>First Release</th>
      <th>Final Release</th>
    </tr>
  </thead>

Manually editing it to thead-dark gives the expected result, but I haven't
looked at the code to see why it isn't switched automatically.

Lack of !important tags I think (which we're trying to avoid).

Removing the class entirely seems fine though. I've pushed a commit to do that - there were a ton of places affected that I found once I managed to reproduce the issue on Ubuntu. Figured it was better to get it out ASAP and then quibble over better ways to do it than leave folks unable to read the site.

Please re-check!
 
--

pgsql-www by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Dark mode styling for the website
Next
From: Daniel Gustafsson
Date:
Subject: Re: Dark mode styling for the website