Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum - Mailing list pgadmin-hackers

Hello,

It is to make it clear which shortcut test is failing, something similar to the query tool tests.

If you want I can separate those in 2 separate patches

Thanks

Joao

On Tue, Feb 20, 2018 at 12:05 PM Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Feb 20, 2018 at 4:51 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:

Hello Dave,

No there is only tests around the the backendsupport function

Let me rephrase :-). What's this part of the patch for?

--- a/web/pgadmin/feature_tests/keyboard_shortcut_test.py

+++ b/web/pgadmin/feature_tests/keyboard_shortcut_test.py

@@ -7,9 +7,10 @@

 #

 ##########################################################################

 

-import os

-import json

+from __future__ import print_function

 import time

+import sys

+

 from selenium.webdriver.support.ui import WebDriverWait

 from selenium.webdriver.support import expected_conditions as EC

 from selenium.webdriver.common.by import By

@@ -64,6 +65,8 @@ class KeyboardShortcutFeatureTest(BaseFeatureTest):

                 Keys.ALT

             ).perform()

 

+            print("Executing shortcut: " + self.new_shortcuts[s]['locator'] + "...", file=sys.stderr, end="")

+

             self.wait.until(

                 EC.presence_of_element_located(

                     (By.XPATH, "//li[contains(@id, " +

@@ -76,6 +79,8 @@ class KeyboardShortcutFeatureTest(BaseFeatureTest):

 

             assert is_open is True, "Keyboard shortcut change is unsuccessful."

 

+            print("OK", file=sys.stderr)

+ 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company