Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220
Date
Msg-id CA+OCxoxffLLmU=Q2kzkfmWwK1W0Ah=BYOd+JDFgUTb-1BU-KTw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view


On Friday, October 14, 2016, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Friday, October 14, 2016, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the below 2 bugs.

RM 1603: [Web Based] Export database failed if object contains double quotes.
RM 1220: Backup database is not working with special characters

The issues which were fixed:

1. Client side data were not unescaped
2. Required command line arguments were quoted twice 

This is not working for me: I tested using Table Export as per Fahar's instructions. As I'm in desktop mode, the first problem was that we get an error at line 210 of import_export/__init__.py, because get_server_directory returned None for the directory. If I fix that, then the job says it's created, but as far as I can see, nothing else happens. 

Oh, oh, oh - 30 minutes later I restarted pgAdmin and got a failed job message!

Copying table data 'q m g r o c k s.q m g r o c k s ' on database 'q m g r o c k s' for the server - 'EPAS 9.5 (172.16.254.22:5444)'
Running command:
/Library/PostgreSQL/9.6/bin/psql --host "172.16.254.22" --port "5444" --username "enterprisedb" --dbname "q m g r o c k s" --command "\copy "q m g r o c k s"."q m g r o c k s " ("q m g r o c k s") TO 'Users/dpage/foo.csv' DELIMITER ';' CSV QUOTE '"' ESCAPE '''';"

Start time: Fri Oct 14 2016 16:21:06 GMT-0700 (PDT)
Users/dpage/foo.csv: No such file or directory 


Looks like it lost the leading / on the path, so that might have been my hacky fix for the first issue.


Secondly, this patch seems to push quoting responsibilty to the front end. This doesn't seem right, because we might want to use the RESTful APIs for another purpose in the future, which would mean needing to re-implement quoting if something else uses an affected API.

Thanks.


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Include wait information on the activity tab of the d