Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question
Date
Msg-id CA+OCxoxfAT5CavRZVT=ET9NBT5Lw4YU6qp4cVVxjnwOYZx6eXw@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question  (Matthew Kleiman <mkleiman@pivotal.io>)
Responses Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - Thatis the Question  (Matthew Kleiman <mkleiman@pivotal.io>)
List pgadmin-hackers
Tree view


On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:
Hi Hackers!

We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before they're opened. There have been a few merge conflicts already in this area and without tests it is difficult to resolve these with high confidence. 

The function in question is the callback for onSelectedRangesChanged. In the latest commit on master (12fa02), it's from line 696 to 773.

Inline image 1


Sounds sensible. Do you have a proposed patch?
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Robert Eckhardt
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience
Next
From: Surinder Kumar
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query ResultsGrid User Experience