Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix) - Mailing list pgadmin-hackers

From Dave Page
Subject Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)
Date
Msg-id CA+OCxoxRwfB7mLcsFyqAto8Dt_KH-hVsbFQvQs7Yu6cascdK9A@mail.gmail.com
Whole thread Raw
In response to pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)  (Dhiraj Chawla <dhiraj.chawla@enterprisedb.com>)
Responses Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)  (Dhiraj Chawla <dhiraj.chawla@enterprisedb.com>)
List pgadmin-hackers
Hi

On Fri, Mar 1, 2013 at 11:46 AM, Dhiraj Chawla
<dhiraj.chawla@enterprisedb.com> wrote:
> Hi Dave,
>
> Attached is the patch that fixes the issue where if a user connects to
> a server, and then tries to add an entry to pg_hba.conf via
> pgHbaConfig form dialog and the newly added entry does not get saved.
>
> Actually a member variable 'isComment' in the pgHbaConfigLine class
> was not initialized. This class stores data of each line of the
> pg_hba.conf file. On some system the default value was set to true
> while on others it was getting set to false. But for empty lines if it
> is set to true, the other logic in pgHbaConfig form dialogs works as
> expected and the newly added entry is getting saved properly.
>
> Let me know your feedback on the same.

Thanks - works for me! Patch committed.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix the editing of pg_hba.conf files.
Next
From: Dhiraj Chawla
Date:
Subject: Re: pgAdmin changing pg_hba.conf does not work - Mac and Windows (Fix)