Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field - Mailing list pgadmin-hackers

From Dave Page
Subject Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field
Date
Msg-id CA+OCxoxKLYhikMGLUVVW=EVMQ_8dEKLv24r=HoXGmaaqgjvaHQ@mail.gmail.com
Whole thread Raw
In response to Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Thanks, committed.

On Wed, Jun 30, 2021 at 1:11 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 30, 2021 at 12:36 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jun 30, 2021 at 3:35 PM Dave Page <dpage@pgadmin.org> wrote:
Here's a simple patch for $SUBJECT. It will remove any leading spaces from the grid cell display and replace them with '[...] '. In edit mode, the data is unchanged.

The patch looks good to me. 

Thanks.
 
Do we need to specify somewhere what is [...] ?

I don't think there's much point.
 

The only downside I can see to this is that the tooltip will show the modified data when it probably should actually show the un-modified data. Unfortunately that's handled by a SlickGrid plugin, which would have to be vendorised and modified (perhaps non-trivially). I don't think that's a big issue though.

--


--


--

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Remove leading whitespace and replace it with '[...]
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Highlighted long running queries on the dashboards. F