Re: Fix for RM3027: Do not SQLQuote parameter values for objects - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Fix for RM3027: Do not SQLQuote parameter values for objects
Date
Msg-id CA+OCxoxJq59W76iNcEos++LmvCi82m+mE8Q295LDWTwO+kcWNQ@mail.gmail.com
Whole thread Raw
In response to Fix for RM3027: Do not SQLQuote parameter values for objects  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Fri, Feb 2, 2018 at 11:20 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

If user wants to set parameter values which requires quote
(like string values which have space/s in it or have special symbol ($) ) then
he has to input this values with quotes. (See below example)

Also all parameter values are case insensitive and while storing these values postgres
always store them in lower case (as per docs). So values which are in upper case won't need quotes.



Example:

1. User input

Inline image 2

2. Generated SQL

Inline image 3

3. Generated SQL (after saving properties.)

Inline image 4



-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Don't quote variable values used by SET. It'susually
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Ensure we capture notices raised by queries. Fixes#3