Re: Windows build system cleanup - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Windows build system cleanup
Date
Msg-id CA+OCxoxHm2DQewFbhcVH+6FLK6Mut7NkRdgKwrhQQ8geTUOL8Q@mail.gmail.com
Whole thread Raw
In response to Re: Windows build system cleanup  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Thanks - committed. I've updated the Jenkins jobs that run Make.bat with the new variable names. I'll keep an eye out for any failures and fix anything that pops up. Once it's stable I'll remove all the old variables.

On Mon, Jun 1, 2020 at 8:53 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

Patch looks good to me, did eyeball review. 

On Fri, May 29, 2020 at 1:43 PM Dave Page <dpage@pgadmin.org> wrote:
Stupid line endings confusing git :-(. Here's another attempt.

On Fri, May 29, 2020 at 7:30 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave 

Unable to apply the patch. Can you please rebase and send it again.

On Thu, May 28, 2020 at 9:04 PM Dave Page <dpage@pgadmin.org> wrote:
Here's a patch to cleanup the windows build system and make sure 64 bit builds work with modern tools. It also updates the README with a new from-scratch setup process that makes it much easier to setup a Windows build/dev machine.

Please review, but don't apply as I'll need to do that in conjunction with some Jenkins changes.

Note that I haven't tested a 32 bit build as I don't have a working environment for that to hand and don't really want to spend time setting one up before we deprecate it. I'll fix any issues that show up in Jenkins.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Cleanup Windows build scripts and ensure Windows x64
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Ignore venv directories in the tree.