On Mon, Aug 13, 2012 at 9:20 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
>
>>> Ok. So, why is pldbgapi.control file not included? It's there in the
>>> repository, and "make install" copies it to share/extension.
>>
>>
>> If it's there in the repo, then it shouldn't be. The PRE_9_2 branch of
>> code is supposed to be how things looked *before* you started your
>> work - it's the stable branch that we're building the< 9.2 installers
>> from, and certainly shouldn't have been "extensionised", or had any
>> other changes made to it except for bug fixes.
>
>
> Then that was a misunderstanding when we discussed that back in May then
> (http://archives.postgresql.org/pgadmin-hackers/2012-05/msg00022.php). How
> do you prefer to resolve that now? The extensionised code in PRE_9_2 branch
> should work on 9.1, if you include all the right files in the installer,
> including the control file. Or, we can create a new "real" pre-9.2 branch at
> the point before I started any of this work. Or at the point just before the
> commit that turned it into an extension. All the commits prior to that seem
> fairly harmless, but would need to test that it works on all supported
> platforms and server versions.
It cannot be extensionised - it's used on 8.x too. I think the best
option is to drop the branch, and recreate it from the point
immediately prior to your first change, and then cherry pick any
important bug fixes you may have made into the new branch.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
