Re: PATCH: don't save empty favourite queries - Mailing list pgadmin-hackers

From Dave Page
Subject Re: PATCH: don't save empty favourite queries
Date
Msg-id CA+OCxox-1CHygPQJ+MxgZN45YExDUPy+ubxwdiBS--2rtKhKMQ@mail.gmail.com
Whole thread Raw
In response to PATCH: don't save empty favourite queries  (Dmitriy Olshevskiy <olshevskiy87@bk.ru>)
List pgadmin-hackers
Thanks - patch applied!

On Sun, Jun 22, 2014 at 7:13 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:
> Hello again!
> Recently I found, that when you open dialog "Add favourite" in query editor
> and close it without any changes, then in the dialog "Manage favourites"
> there is appears an empty element (i.e. with blank title). I think it's not
> quite right, so I put a small condition in dlgAddFavourite.cpp. It means
> that only if OK button is enabled, then we have a well-formed favourite
> query and can add new item to the favourites. If there will be a free time,
> please take a look at this patch. If I'm wrong, maybe you'll find an correct
> solution of the issue?
> Thank you.
>
> --
> Dmitriy Olshevskiy
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Ensure Favourite queries are only saved when the OK
Next
From: Dave Page
Date:
Subject: Re: Fix for a problem with auto reconnection