Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221 - Mailing list pgadmin-hackers

On Thu, May 3, 2018 at 12:25 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Wed, May 2, 2018 at 6:03 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo

I have reviewed your code and looks good to me. Can we change the message from "The database name is inappropriate" to some meaningful message, so that user should know why it is inappropriate. If user will be able to create database with "=" in name then why Backup, Maintenance and Restore fails.  

Just curious, as I understand the problem, we're not able to able to run pg_dump/pg_restore/psql against the database, which contains '=' in the name.

Can we use PGDATABASE environment variable for them?

This way we can implement, but should we consider this way only in case of the database name having "=" ?

I think - we should do it for all for consistent result. 

Also, the command on the dialogue will not have database name, so user might get confused.

What need to show as the command line is upto us?

We can also show PGDATABASE=XXXX as environment variable for this command.

 

Of course - this tools may still fail when special characters (e.g. '=') exists in the name of the database objects (e.g. schema, table, etc).

It's working with this approach.

Good to know that.

-- Thanks, Ashesh

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi 

On Wed, May 2, 2018 at 3:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch which will fix RMs # 1220 and #1221.

If the database name contains = then the backup, maintenance and restore jobs are failing.

To fix these, we will display the error message regarding inappropriate database name. 

Thanks,

Khushboo

--

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246