Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PGData-types in Query Tool - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PGData-types in Query Tool
Date
Msg-id CA+OCxowuS9S95KNFd0=H6Bmec7ZNx70QQpE7n_N7VODEHfuY2w@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PGData-types in Query Tool
Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PGData-types in Query Tool
List pgadmin-hackers
Tree view
Hi

On Thu, May 11, 2017 at 6:38 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

As we have been facing many issues with different data-type display in Query Tool output, Dave suggested to write the feature test for the same.

I have started with some basic set of data-type values and will add more.
Please find the attached initial patch for the same.

Some thoughts:

- Instead of sleeping, which is almost always a bad design, can we wait for objects to appear?

- Currently you're testing each datatype with an individual query, e.g.

SELECT 32768;

I would suggest we test all datatypes at once, e.g.

SELECT 32768, 43723489023489, '2017-09-12 15:34:11', 12345.56;

etc. That will massively reduce the time taken to execute the tests (which is a big concern).

- Shouldn't we be casting the values in the SELECT, so we (and the database) know exactly what we're expecting? e.g.

SELECT 32768::int, 43723489023489::bigint, '2017-09-12 15:34:11':timestamp, 12345.56::numeric(8,4);

That would also allow us to verify the type name displayed in the column headers.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insertrow doesn't use default values
Next
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PGData-types in Query Tool