Re: [pgAdmin4][Debugger]: Initial Patch - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Debugger]: Initial Patch
Date
Msg-id CA+OCxowidzrBrk1C-Z4JyF5Hqpk43TY8RQXtPwHd5TCgBdQQ8g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Debugger]: Initial Patch  (Neel Patel <neel.patel@enterprisedb.com>)
Responses Re: [pgAdmin4][Debugger]: Initial Patch  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
On Wed, Apr 6, 2016 at 8:57 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi Dave,
>
> I got the root cause. Issue will reproduce when we applied Akshay's query
> tool patch.
> Issue was once the panel was initialized, HTML file was not getting loaded
> in to the panel due to the change in frame.js.
>
> Both query tool and debugger patch file contains the change in "frame.js"
> file. Once you applied the query tool patch and after that debugger then
> debugger patch should fail but i don't know why you do not get any error.
>
> Solution:-
>
> Open "frame.js"  file and add the below line in "setTimeout" function which
> is required by debugger.
>
>                  pgBrowser.Events.trigger('pgadmin-browser:frame:urlloaded:'
> + that.name, frame, that.url, self);
>
> Do let us know if you still face the same issue.

Ahh, good catch - that got it :-)

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: [pgAdmin4][Debugger]: Initial Patch
Next
From: Ashesh Vashi
Date:
Subject: Re: [pgAdmin4][Patch]: Backgrid StringDepsCell