Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure &Trigger Function modules - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure &Trigger Function modules
Date
Msg-id CA+OCxowf9-Dasizbphm-UxvpiBVPjigReBduhK3gU=o6yJeNPA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure &Trigger Function modules  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Of course, yes you're correct. Thanks - patch applied.

On Thu, Jul 6, 2017 at 3:59 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Sorry, I think my last statement was misleading.

No, It's not broken, I meant the behaviour is taken from pgAdmin3, It is disabled by default but once you change the value of "Returns a set?" (under Options tab) to Yes while creating new function it gets enabled.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jul 6, 2017 at 6:37 PM, Dave Page <dpage@pgadmin.org> wrote:
Maybe, but it's pretty clearly broken, so whilst you're fixing the template for that value, it would make sense to fix the UI too :-)

On Thu, Jul 6, 2017 at 1:42 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

This behaviour is from beginning I think and it is inherited from pgAdmin3.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jul 6, 2017 at 5:58 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jul 6, 2017 at 12:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue in Function, Procedure & Trigger Function modules where user was not able to update object if user changes the code definition. 
RM#2537

This still doesn't seem quite right - the Rows field seems to be always greyed out, so I cannot set it to test at all. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix the formatting of the ROWS option for functionse
Next
From: pgAdmin 4 Jenkins
Date:
Subject: Jenkins build is back to normal : pgadmin4-master-python26 #343