Re: [HACKERS] pg_ls_waldir() & pg_ls_logdir() - Mailing list pgsql-hackers

From Dave Page
Subject Re: [HACKERS] pg_ls_waldir() & pg_ls_logdir()
Date
Msg-id CA+OCxoweEO98gWOsBDD5T0SgdEwPk7ChVz-A7wae1dnLNOeOwA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] pg_ls_waldir() & pg_ls_logdir()  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [HACKERS] pg_ls_waldir() & pg_ls_logdir()  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Mar 16, 2017 at 9:54 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Thu, Mar 16, 2017 at 10:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>>> +        const int n = snprintf(NULL, 0, "%lld", attrib.st_size);
>
> I wonder what the portable printf directive is for off_t.  Maybe
> better to use INT64_FORMAT and cast to int64?

Hmm, good point. Google seems to be saying there isn't one. Patch
updated as you suggest (and I've added back in a function declaration
that got lost in the rebasing of the last version).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] Partitioned tables and relfilenode
Next
From: Nikhil Sontakke
Date:
Subject: Re: [HACKERS] Speedup twophase transactions