Re: pgAdmin Event Trigger Compatibility - Mailing list pgadmin-hackers

H

i Dave,

OK, it builds fine on Mac for me now. Some initial feedback:

- Instead of "DDL_COMMAND_START", we should use "DDL COMMAND START". The same applies to similar cases.

Fixed it.

 

- Can we combine the Enable and Enable Status options into one set of radio buttons, e.g. Enabled (which should be the default), Replica, Always and Disabled?

Yes, we can change this enable check box as a radio button. But, "REPLICA/ALWAYS" are two enable's properties. Hence, We have implemented this in the proposed way. Kindly share your opinion on this.

 

- Please fix the sizing of the box around the aforementioned radio buttons. See the screen shots for an example of what I mean. It should match the "Fires" box on dlgTrigger.

Fixed it.

Please find the new patch which fixes the above issues, except including the "Enable" check box in radio group.

Thanks in advance.

Dinesh

-- 
Dinesh Kumar

Software Engineer

Ph: +918087463317

Skype ID: dinesh.kumar432

www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more