Re: [pgadmin-hackers][patch] Column selection on SQLEditor - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin-hackers][patch] Column selection on SQLEditor
Date
Msg-id CA+OCxowW=Ji9AacTdbwCEj_rvJq6T19LUqwCYF+TuEtoAB1r-A@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers][patch] Column selection on SQLEditor  (Atira Odhner <aodhner@pivotal.io>)
Responses Re: [pgadmin-hackers][patch] Column selection on SQLEditor  (Matthew Kleiman <mkleiman@pivotal.io>)
List pgadmin-hackers
On Fri, Apr 7, 2017 at 2:49 PM, Atira Odhner <aodhner@pivotal.io> wrote:
>> The one tweak I made to the patch was to remove the code that disabled
>> the Copy button from the top of copy_data.js. I think the button
>> should remain enabled to allow the user to copy again, in case they
>> use the clipboard for something else and then need to refresh it with
>> the data. Of course, it should still be disabled when there is nothing
>> selected that can be copied.
>
> Yes, the copy button enablement behavior was a bit strange.  I'm glad you
> found a fix for it. Do you mind sending us your updated patch?

I literally just removed lines 5 & 6 of copy_data.js.

>> Any chance this can be fixed before Monday? I would like to include it
>> in the release if possible
>
> I'll drop a bug at the top of our backlog, and Matt will take a look at it
> today. We'll let you know at the end of the day where we're at with this
> fix.

Thanks - and sorry to hear your moving onto other things :-(

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Sarah McAlear
Date:
Subject: Re: [pgadmin-hackers][patch] Move to Alembic migration system
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Adding a delay clearly didn't fix the feature tests: