Postgres Pro
Downloads
Home   >   mailing lists

Re: JS Test error on Windows - Mailing list pgadmin-hackers

From Dave Page
Subject Re: JS Test error on Windows
Date
Msg-id CA+OCxowUyxDkSSAM7pqxpuxK3JQBvJ8NXKsTS95FGr7wkuuiSw@mail.gmail.com
Whole thread Raw
In response to Re: JS Test error on Windows  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: JS Test error on Windows
List pgadmin-hackers
Tree view


On Fri, May 11, 2018 at 7:28 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Dave/Hackers,

PFA fix for the problem. The RegEx for webpack test is not working on windows because the path separator is different for Windows( \ ) and Unix( / ). And so, the imports loader is not executing for slickgrid.
Patch tested on Win 10, Win 7, Ubuntu, Cent OS and works fine.

Nice catch! How did you figure that one out?

Patch applied.
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Fix webpack config regexps to be moreWindows-friendl
Next
From: Aditya Toshniwal
Date:
Subject: Re: JS Test error on Windows