Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM #3933 Error dropping database pop upmessage displayed if user try to drop any database with Arabic character withnon super user - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM #3933 Error dropping database pop upmessage displayed if user try to drop any database with Arabic character withnon super user
Date
Msg-id CA+OCxowT5phAb3RSEAhW_8v7rELqcuyVvpkJ4K3hRYGRdLRuGg@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: RM #3933 Error dropping database pop up messagedisplayed if user try to drop any database with Arabic character with nonsuper user  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM #3933 Error dropping database pop upmessage displayed if user try to drop any database with Arabic character withnon super user  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Wed, Feb 27, 2019 at 7:50 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix RM #3933 "Error dropping database pop up message displayed if user try to drop any database with Arabic character with non super user". There is an exception in the logging system for Arabic characters. 

I have read https://docs.python.org/2/library/logging.html#logging.Handler.handleError and as part of fix set logging.raiseException = False

Please review it.

I'm fine with ignoring exceptions in the logger, but we should be able to log messages with UTF-8 characters in them surely? Is this just that we need to apply proper conversion to the error message, or does it occur in this case because the cluster was initialised in utf-8, but the maintenance DB is in some other encoding (which is a weird situation which can cause potential problems when working with global objects)?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Use POST instead of GET for Query Tool downloads toa