Re: PATCH: SlickGrid integration in query tool (pgAdmin4) - Mailing list pgadmin-hackers

This is looking awesome! I think there are some tweaks to make, but performance-wise, it's blowing away the old code. My tests show it's even faster than you're seeing; I'm seeing ~3x performance rendering 21K rows for example, vs. the first 2K of the same dataset on page 1 with the old code - plus, the rendered HTML isn't so huge that it slows everything else down to being unusable!

Can you look at the following issues please?

1) The colour for a selected row should be #eeeeee

2) If there's a horizontal scroll bar (in Chrome on OSX, possibly others), then it partially eclipses the new blank row in View Data mode. The vertical scroll needs to have the height of the horizontal scrollbar added.

3) If the window is resized, the grid doesn't redraw to the new size.

4) I cannot leave a Primary Key field blank so that it picks up a default value (I get "Primary key columns cannot be null.")