Re: [pgadmin-hackers] [patch] upgrade slickgrid - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin-hackers] [patch] upgrade slickgrid
Date
Msg-id CA+OCxowQ6r1MfqnNptyD+DeOv8oQNNU7Apa4rSTKvW9b3ZYUGQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [patch] upgrade slickgrid  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] [patch] upgrade slickgrid
List pgadmin-hackers


On Wed, May 17, 2017 at 1:59 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, May 15, 2017 at 7:35 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Hackers

We upgraded SlickGrid to the latest version + 53ee34. We upgraded since we are working on some changes to the query results functionality, including improvements to column selection and shortcuts.

This SlickGrid upgrade includes a PR we wrote that simplifies some of these changes.

Please note that we are not requesting this be included in the 1.5 release.

Have you confirmed that removing the changes we made to shorten the class names used for rows and cells doesn't affect the performance or memory utilisation of the grid? 

Also... would this be an appropriate time to remove the embedded libraries altogether, and move to npm/yarn installations of them? 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [patch] upgrade slickgrid
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Various FTS dictionary cleanups. Fixes #1126