Re: [pgAdmin4][Patch]: SYNONYM issue if use all special characters as name - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: SYNONYM issue if use all special characters as name
Date
Msg-id CA+OCxowOu2rWz7Vy9Q4Z8w3H_7ppm4vV=aFk=tbGT71vo+Bzzw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch]: SYNONYM issue if use all special characters as name  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Friday, October 14, 2016, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi

Issue:
If synonym name contains special characters, the request url is be '404 not found'.
i.e. It doesn't hit at 'sql' method of synonym.

Solution:
If URL has an identifier containing slash character '/' into the URI, then set param type to path.
like /<path: int>.
Because if param name contains '/' in synonym name, it gets confused and wrong route is formed.

Please find attached patch and review.

Thanks,
Surinder Kumar


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Handle reverse engineering of synonyms with / in the
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220