- In View Data query tool, explain related buttons should be disabled
- Autocomplete design changes
I have also fixed one issue which was created by the copyright changes in the file - pgadmin/misc/file_manager/templates/file_manager/js/languages/en.js. The en.js file contains json data and adding copyright comments to it caused JSON parsing failure in file dialog. As an improvement, I have renamed the file from en.js to en.json at all the places to avoid such changes in future.
Kindly review.
Thanks - applied.
A few other things that I noticed (or have been bugging me):
- The menu bar seems a little cramped. Taking pg-navbar from 32 to 40px and setting the font-weight to normal on the menu options (but not the product name) seems much better to me (and adjusting everything else as required of course).
- In the file dialogue, the column headers don't line up with the columns in the rows.
- In list mode of the file dialogue, can we use the same coloured icons as we do in icon mode? Obviously smaller...
- "Show hidden files and folders ?" shouldn't have a space before the question mark.
- The menu bar on the file dialogue doesn't match the styling of the menu bar on the query tool (in fact, even the left and right ends of it are styled differently from each other).
- The line numbers in the gutter of CodeMirror are tiny.
- I'm not convinced about the boldness of the tab titles - I think the are just a little too harsh - can you change the font-weight to normal for them please (both the wcDocker and Bootstrap tabs)?
Also (for another day); we should move the file dialog messages out of the JSON file altogether and use our normal translation mechanisms.
