Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#3238] Proper error handling when connection will belost to server. - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][RM#3238] Proper error handling when connection will belost to server.
Date
Msg-id CA+OCxow47ySKxNBTLNnbjGRSM8u7f-0Byvr7p7nDH8DX+i-7+A@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM#3238] Proper error handling when connection will belost to server.  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.  (Anthony Emengo <aemengo@pivotal.io>)
List pgadmin-hackers
Tree view
Hi

On Thu, May 3, 2018 at 11:23 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

PFA patch for proper error handling when connection will be lost to server. I have created a common function alertify.pgRespErrorNotify in web/pgadmin/static/js/alertify.pgadmin.defaults.js on the lines of existing function alertify.pgNotifier. The function is called in error callback of $.ajax call. The XHR is passed and handled in the function itself. Please note that I have used JSON.parse and not $.parseJSON as it will be deprecated in jQuery 3.x and thus removing many $.parseJSON calls.

Request you to kindly review.

Can you add some appropriate tests for the new function please? 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: [pgAdmin4][RM#3238] Proper error handling when connection will belost to server.
Next
From: Anthony Emengo
Date:
Subject: Re: [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.