Re: [pgagent] patch: link with -pthread - Mailing list pgadmin-support

From Dave Page
Subject Re: [pgagent] patch: link with -pthread
Date
Msg-id CA+OCxow3hxd=gmMF5F+86QyJgn188nAcG-jfxTF9cW5+1txSgQ@mail.gmail.com
Whole thread Raw
In response to [pgagent] patch: link with -pthread  (Christoph Berg <myon@debian.org>)
Responses Re: [pgagent] patch: link with -pthread  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-support
Hi

On Fri, Jul 20, 2018 at 9:55 AM, Christoph Berg <myon@debian.org> wrote:
All non-x868 architectures need -pthread to link with threads:

https://buildd.debian.org/status/logs.php?pkg=pgagent&ver=4.0.0-1&suite=sid

This patch fixes the problem:

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -135,7 +135,7 @@ ENDIF(WIN32)

 ADD_EXECUTABLE(pgagent ${_srcs})
 TARGET_LINK_LIBRARIES(
-        pgagent ${PG_LIBRARIES} ${Boost_LIBRARIES}
+        pgagent ${PG_LIBRARIES} ${Boost_LIBRARIES} -pthread
 )

 # Installation

That throws a nice warning on macOS (unused-command-line-argument) as I suspected it might. I'll bet Windows barfs on it too.

Neel, can you look and see what is the best solution here please? I'm guessing you still have build environments for all platforms from the Boost work you did.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-support by date:

Previous
From: Christoph Berg
Date:
Subject: [pgagent] Instatallation destination?
Next
From: Dave Page
Date:
Subject: Re: [pgagent] Instatallation destination?